Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing a few features from the new Realworld API spec. #76

Open
h6w opened this issue Mar 3, 2019 · 1 comment
Open

Missing a few features from the new Realworld API spec. #76

h6w opened this issue Mar 3, 2019 · 1 comment

Comments

@h6w
Copy link

h6w commented Mar 3, 2019

The new postman tests at https://github.com/gothinkster/realworld/blob/master/api/Conduit.postman_collection.json are failing a few tests when run against the node-experess backend repos.

Namely:

User: 'bio' and 'image' property are missing.
Article: "updatedAt" property is missing.
"celeb_" test fails. At first glance, this looks like a test for emails with underlines, but I'm probably wrong.

@larswww
Copy link

larswww commented Oct 29, 2019

"celeb_" test fails because the regex in the User mongoose model only allows letters and numbers!

models/User.js 12:
match: [/^[a-zA-Z0-9]+$/, 'is invalid']

Changing to
match: [/^[a-zA-Z0-9_]+$/, 'is invalid']
will make things run.

The bio and image features aren't implemented it seems? Is anyone working on those? I could probably get that done if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants