Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell me about how you use your own separate libraries in this project #70

Open
HelgeStenstrom opened this issue Jan 21, 2020 · 3 comments
Assignees
Labels

Comments

@HelgeStenstrom
Copy link
Contributor

I'm curious to how you work with changes in java-stream-player that you do for the needs of XR3Player.

Do you use java-stream-player as a compiled jar-file when you run XR3Player?
If so, do you download it from the same repository as I get it from, or is it just local on your machine?
If it's on your local machine, can you have the same pom.xml file as I have, i.e., the same as exists here on GitHub? Or do you tweak the pom file to look in a local repository?
What is the turn-around time from a small change in java-stream-player until you can test it in XR3Player?

@goxr3plus
Copy link
Owner

goxr3plus commented Jan 22, 2020

  • How i test it ?

Actually i have it locally and building it locally , and Maven has a special dependency syntax to use your local jars , as far as you can see if you run mvn clean install on java-stream-player it biulds automatically a new jar :) .

One more thing you can do is create a new tag every x changes for example 9.1.2 , 9.1.3 and everytime rebuild with JitPack and test it.

Locally is faster i thing.

Here is the syntax you need for local jar with Maven .
https://stackoverflow.com/questions/4955635/how-to-add-local-jar-files-to-a-maven-project

Please have a look so you find the best solution , i had it on the pom file , i removed it how i was doing it , so i could give you the code directly :)

  • How i use it ?

java-stream-player is a maven java repository , i am using JitPack , so everytime i make changes and a new release of java-stream-player i can just add it as a dependency using JitPack , look here https://jitpack.io/private#goxr3plus/java-stream-player

I have not tested java-stream-player since 5 months because it became more complex and it will take time testing compatibility with XR3Player.

@HelgeStenstrom

@goxr3plus goxr3plus self-assigned this Jan 22, 2020
@HelgeStenstrom
Copy link
Contributor Author

So if I understand it correctly, when you do changes in a library that XR3Player depends on, for the sake of XR3Player, your pom.xml file is somewhat different than the one published here on GitHub. Do you use the solution by Alireza Fattahi, which has the most votes on stackoverflow? It's said to be deprecated, but still work. Or do you use some variant of it?

@goxr3plus
Copy link
Owner

I found it :) =>

XR3Player/pom.xml

Lines 339 to 351 in 40ceb19

<!-- Locally testing WebBrowser -->
<!-- <dependency> <groupId>JavaFX-Web-Browser</groupId> <artifactId>com.JavaFX-Web-Browser</artifactId>
<version>1.0</version> <scope>system</scope> <systemPath>${project.basedir}/libraries/JavaFXWebBrowser-3.5.0.jar</systemPath>
</dependency> -->
<!-- XR3Capture -->
<!-- <dependency> <groupId>com.github.goxr3plus</groupId> <artifactId>xr3capture</artifactId>
<version>V9.12</version> <exclusions> <exclusion> <groupId>com.jfoenix</groupId>
<artifactId>jfoenix</artifactId> </exclusion> <exclusion> <groupId>org.controlsfx</groupId>
<artifactId>controlsfx</artifactId> </exclusion> </exclusions> </dependency> -->
<!-- Locally testing XR3Capture -->
<!-- <dependency> <groupId>com.XR3Capture</groupId> <artifactId>XR3Capture</artifactId>
<version>1.0</version> <scope>system</scope> <systemPath>${project.basedir}/libraries/XR3Capture-3.12.jar</systemPath>
</dependency> -->

----------- GENERALLY TALKING YOU MAY NOT NEED ---------------------------------------
Useful here .

Have a look on this link also here .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants