Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate selective generation or loading of attribute proto messages #24

Open
suyashkumar opened this issue Sep 14, 2018 · 1 comment
Open

Investigate selective generation or loading of attribute proto messages #24

suyashkumar opened this issue Sep 14, 2018 · 1 comment
Labels
enhancement New feature or request investigation

Comments

@suyashkumar
Copy link
Contributor

Projects that import or use Attributes.proto end up importing huge swaths of autogen'd code (that can increase binary sizes or load times). Some potential fixes include:

  • Extending dicom-protos to take a flag to only generate some subset of DICOM attribute messages that may be needed by a client
  • Restructuring autogen'd code so that specific DICOM attribute messages can be imported without the others (can be done with autogen'd import statements, or some other type of dependency injection)
@suyashkumar suyashkumar added enhancement New feature or request investigation labels Sep 14, 2018
@suyashkumar
Copy link
Contributor Author

Attributes_pb.js is 10.8Mb of source, golang source file is >3 Mb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suyashkumar