Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Please start using Semantic Versioning #103

Open
KateGo520 opened this issue Aug 7, 2020 · 2 comments
Open

Proposal: Please start using Semantic Versioning #103

KateGo520 opened this issue Aug 7, 2020 · 2 comments

Comments

@KateGo520
Copy link

I found that this project already supports Go modules. But sadly, the [tags](https://github.com https://github.com/grafana-tools/sdk/tags) doesn't follow Semantic Versioning, which means that all tags of this project will be ignored by Go modules and replaced by pseudo-versions, go get acts weirdly when tags are not in that form. It would be great to have the tagged release be named in the format vX.X.X format so that go mod can read it.

	github.com/grafana-tools/sdk v0.0.0-20200802204627-e6a8cdd8fef5

Else the mod file shows something like github.com/grafana-tools/sdk v0.0.0-20200802204627-e6a8cdd8fef5 which is not very readable and difficult to upgrade. It’s hard to verify which version is in use. This is not conducive to version control.

So, I propose this project to follow Semantic Versioning in future versions. For example, v1.0.1, v2.0.0, v3.1.0-alpha, v3.1.0-beta.2etc, so that other project can use tag in go.mod.

@KateGo520
Copy link
Author

@GiedriusS @K-Phoen Could you help me review this issue? Thx :p

@GiedriusS
Copy link
Collaborator

Yes, we should start doing this starting with v1.0.0 once #47 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants