Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for gauge panel type #126

Open
tonykoh opened this issue Mar 2, 2021 · 1 comment · May be fixed by #127
Open

add support for gauge panel type #126

tonykoh opened this issue Mar 2, 2021 · 1 comment · May be fixed by #127

Comments

@tonykoh
Copy link

tonykoh commented Mar 2, 2021

Currently, if we try to create a dashboard using json model containing a gauge panel, it will be marshalled as a custom panel instead of a gauge panel. Due to json nesting of custom panel, targets.expr for the gauge panel will not be parse and no data is displayed on the gauge.

Proposal: Add GaugePanel struct in panel.go

@GiedriusS
Copy link
Collaborator

Sure! Feel free to add support for it. It would be nice to even have tests such as this for it: https://github.com/grafana-tools/sdk/blob/master/board_visual_test.go. Just a simple test to add a dashboard with that panel, upload it, and check if it appears at least.

@tonykoh tonykoh linked a pull request Mar 3, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants