Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diff flame graph view] Improve Auto-select logic #243

Open
grafakus opened this issue Oct 25, 2024 · 0 comments
Open

[diff flame graph view] Improve Auto-select logic #243

grafakus opened this issue Oct 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@grafakus
Copy link
Contributor

grafakus commented Oct 25, 2024

Feature description

Is your feature request related to a problem? Please describe.

Context: this PR introduced the "Auto-select" button

This issue is a placeholder to find ways to improve the auto-selection:

  • Idea 1: Auto-select should not behave the same if there are different filters in baseline & comparison: if the filters are different, selecting the whole time range makes sense, if they are the same, selecting half of the range makes more sense
  • Idea 2: leverage machine learning (see the example of Explore Logs) to implement @Rperry2174's idea: "the auto-select button should pick the 5 minutes on either side of the lowest point on the baseline graph as the baseline. the button should pick the 5 minutes on either side of the highest pint for the comparison".

Describe the solution you'd like

See above

Alternatives considered

-

Additional context

-

@grafakus grafakus added the enhancement New feature or request label Oct 25, 2024
@grafakus grafakus changed the title [diff flame graph view] Auto-select should behave differently if the filters are different in baseline & comparison [diff flame graph view] Improve Auto-select logic Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant