Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrafanaContactPoint doesn't support values from secretkeyref #1595

Open
jacobaccumulus opened this issue Jun 26, 2024 · 5 comments · May be fixed by #1670
Open

GrafanaContactPoint doesn't support values from secretkeyref #1595

jacobaccumulus opened this issue Jun 26, 2024 · 5 comments · May be fixed by #1670
Assignees
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jacobaccumulus
Copy link

Is your feature request related to a problem? Please describe.
Trying to add pagerduty contact point, realized I cannot inject the integration key from a kubernetes secret.

Describe the solution you'd like
valuesfrom secretkeyref functionality identical to that in the GrafanaDataource CR

Describe alternatives you've considered
Potentially possible to work around with env vars but not ideal or consistent with best practices.

@jacobaccumulus jacobaccumulus added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 26, 2024
@theSuess theSuess added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 1, 2024
@audriusb
Copy link

yes please. i'd like that as well.

@joelp172
Copy link

+1. Currently the only way to create a slack contact point is to hardcode the webhook and commit it to git. This is not secure and against all best practice. In a similar way to data sources, been able to specify values from secrets would be the solution.

@Fantaztig
Copy link

Same for webhooks! Not sure about the other use cases, could it be enough to allow referencing a Secret in a 'secureSettings' field?

@theSuess theSuess self-assigned this Aug 26, 2024
@sanketgawade
Copy link

We are also looking for this since, we are trying setup PagerDuty contactpoints and have to put keys as plain text.
Is this work in progress ?

@theSuess theSuess linked a pull request Sep 9, 2024 that will close this issue
@theSuess
Copy link
Member

theSuess commented Sep 9, 2024

I've created #1670 to implement this - please take a look if the proposed syntax would work for your use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants