Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Services are not selectable by label selectors independently #3275

Open
sringel opened this issue Aug 16, 2024 · 0 comments
Open

Comments

@sringel
Copy link

sringel commented Aug 16, 2024

Goal:

Selecting of the base or headless service independently should be possible with label selectors.

Problem:

The labels generated for both services are not unique and hence there isn't a combo of labels that can be used to independently select an individual service.

Workaround (Partial):

Add a label to the base service using:

service:
  labels:
    some-label-key: some-value

This will allow the base service to be selected but not the headless service. It is also not future proof as the headless service template may at some point be updated to include .Values.service.labels.

Recommended action:

Add a label to both service templates that ensures the labels on each service will always be unique.

Base service
grafana.com/grafana-service-type: base

Headless service
grafana.com/grafana-service-type: headless

@sringel sringel changed the title [grafana] Default labels added to services are not unique enough to be selectable by label selectors independently [grafana] Services are not selectable by label selectors independently Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant