From 84d964924b88120d4d603abd73215a07d0ebdbf5 Mon Sep 17 00:00:00 2001 From: Wylie Hobbs Date: Wed, 3 Apr 2024 09:34:38 -0600 Subject: [PATCH 1/3] chore: set unique cluster_label for tempo-distributed memberlist Signed-off-by: Wylie Hobbs --- charts/tempo-distributed/Chart.yaml | 2 +- charts/tempo-distributed/values.yaml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/charts/tempo-distributed/Chart.yaml b/charts/tempo-distributed/Chart.yaml index 18c2188f09..674faac075 100644 --- a/charts/tempo-distributed/Chart.yaml +++ b/charts/tempo-distributed/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: tempo-distributed description: Grafana Tempo in MicroService mode type: application -version: 1.20.1 +version: 1.21.0 appVersion: 2.6.0 engine: gotpl home: https://grafana.com/docs/tempo/latest/ diff --git a/charts/tempo-distributed/values.yaml b/charts/tempo-distributed/values.yaml index b721222e80..b887a35f3f 100755 --- a/charts/tempo-distributed/values.yaml +++ b/charts/tempo-distributed/values.yaml @@ -1119,6 +1119,7 @@ traces: # -- Memberlist configuration. Please refer to https://grafana.com/docs/tempo/latest/configuration/#memberlist memberlist: node_name: "" + cluster_label: "{{ .Release.Name }}.{{ .Release.Namespace }}" randomize_node_name: true stream_timeout: "10s" retransmit_factor: 2 From 42873daa49865269fd790990c1098269217f617f Mon Sep 17 00:00:00 2001 From: Wylie Hobbs Date: Wed, 3 Apr 2024 09:41:38 -0600 Subject: [PATCH 2/3] update docs Signed-off-by: Wylie Hobbs --- charts/tempo-distributed/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/tempo-distributed/README.md b/charts/tempo-distributed/README.md index 6007c60b6c..e243313951 100755 --- a/charts/tempo-distributed/README.md +++ b/charts/tempo-distributed/README.md @@ -1,6 +1,6 @@ # tempo-distributed -![Version: 1.20.1](https://img.shields.io/badge/Version-1.20.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.6.0](https://img.shields.io/badge/AppVersion-2.6.0-informational?style=flat-square) +![Version: 1.21.0](https://img.shields.io/badge/Version-1.21.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.6.0](https://img.shields.io/badge/AppVersion-2.6.0-informational?style=flat-square) Grafana Tempo in MicroService mode @@ -566,7 +566,7 @@ The memcached default args are removed and should be provided manually. The sett | license.contents | string | `"NOTAVALIDLICENSE"` | | | license.external | bool | `false` | | | license.secretName | string | `"{{ include \"tempo.resourceName\" (dict \"ctx\" . \"component\" \"license\") }}"` | | -| memberlist | object | `{"abort_if_cluster_join_fails":false,"bind_addr":[],"bind_port":7946,"gossip_interval":"1s","gossip_nodes":2,"gossip_to_dead_nodes_time":"30s","leave_timeout":"5s","left_ingesters_timeout":"5m","max_join_backoff":"1m","max_join_retries":10,"min_join_backoff":"1s","node_name":"","packet_dial_timeout":"5s","packet_write_timeout":"5s","pull_push_interval":"30s","randomize_node_name":true,"rejoin_interval":"0s","retransmit_factor":2,"stream_timeout":"10s"}` | Memberlist configuration. Please refer to https://grafana.com/docs/tempo/latest/configuration/#memberlist | +| memberlist | object | `{"abort_if_cluster_join_fails":false,"bind_addr":[],"bind_port":7946,"cluster_label":"{{ .Release.Name }}.{{ .Release.Namespace }}","gossip_interval":"1s","gossip_nodes":2,"gossip_to_dead_nodes_time":"30s","leave_timeout":"5s","left_ingesters_timeout":"5m","max_join_backoff":"1m","max_join_retries":10,"min_join_backoff":"1s","node_name":"","packet_dial_timeout":"5s","packet_write_timeout":"5s","pull_push_interval":"30s","randomize_node_name":true,"rejoin_interval":"0s","retransmit_factor":2,"stream_timeout":"10s"}` | Memberlist configuration. Please refer to https://grafana.com/docs/tempo/latest/configuration/#memberlist | | memcached.affinity | string | Hard node and soft zone anti-affinity | Affinity for memcached pods. Passed through `tpl` and, thus, to be configured as string | | memcached.enabled | bool | `true` | Specified whether the memcached cachce should be enabled | | memcached.extraArgs | list | `[]` | Additional CLI args for memcached | From ecdf88c47af0f02c6d32ac6d7b56e85f64cb8a0c Mon Sep 17 00:00:00 2001 From: Joe Elliott Date: Wed, 6 Nov 2024 13:47:12 -0500 Subject: [PATCH 3/3] readme Signed-off-by: Joe Elliott --- charts/tempo-distributed/README.md | 5 +++++ charts/tempo-distributed/README.md.gotmpl | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/charts/tempo-distributed/README.md b/charts/tempo-distributed/README.md index e243313951..b2952c2d5b 100755 --- a/charts/tempo-distributed/README.md +++ b/charts/tempo-distributed/README.md @@ -46,6 +46,11 @@ The command removes all the Kubernetes components associated with the chart and A major chart version change indicates that there is an incompatible breaking change needing manual actions. +### From Chart versions < 1.21.0 + +Upgrading to chart 1.21.0 will set the memberlist cluster_label config option. During rollout your cluster will temporarilly be split into two memberlist clusters until all components are rolled out. +This will interrupt reads and writes. This config option is set to prevent cross talk between Tempo and other memberlist clusters. + ### From Chart versions < 1.18.0 Please be aware that we've updated the minor version to Tempo 2.6, which includes breaking changes. diff --git a/charts/tempo-distributed/README.md.gotmpl b/charts/tempo-distributed/README.md.gotmpl index e6b2e33433..c920695412 100644 --- a/charts/tempo-distributed/README.md.gotmpl +++ b/charts/tempo-distributed/README.md.gotmpl @@ -39,6 +39,11 @@ The command removes all the Kubernetes components associated with the chart and A major chart version change indicates that there is an incompatible breaking change needing manual actions. +### From Chart versions < 1.21.0 + +Upgrading to chart 1.21.0 will set the memberlist cluster_label config option. During rollout your cluster will temporarilly be split into two memberlist clusters until all components are rolled out. +This will interrupt reads and writes. This config option is set to prevent cross talk between Tempo and other memberlist clusters. + ### From Chart versions < 1.18.0 Please be aware that we've updated the minor version to Tempo 2.6, which includes breaking changes.