Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go 1.23 #9033

Closed
chenrui333 opened this issue Aug 18, 2024 · 3 comments
Closed

Support go 1.23 #9033

chenrui333 opened this issue Aug 18, 2024 · 3 comments

Comments

@chenrui333
Copy link

While regression build mimir-2.13.0 release with go1.23, seeing some build failure as below:

  ==> make BUILD_IN_CONTAINER=false GENERATE_FILES=false cmd/mimirtool/mimirtool
  CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build -ldflags " -X github.com/grafana/mimir/pkg/util/version.Branch=HEAD -X github.com/grafana/mimir/pkg/util/version.Revision=4775ec156 -X github.com/grafana/mimir/pkg/util/version.Version=2.13.0 -extldflags \"-static\" -s -w" -tags netgo,stringlabels -o "cmd/mimirtool/mimirtool""" ./cmd/mimirtool
  # github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
  vendor/github.com/grafana/pyroscope-go/godeltaprof/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond
  vendor/github.com/grafana/pyroscope-go/godeltaprof/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame
  make: *** [cmd/mimirtool/mimirtool] Error 1

full error log, https://github.com/Homebrew/homebrew-core/actions/runs/10435665714/job/28899862243

@charleskorn
Copy link
Contributor

We have no plans to support building Mimir 2.13 with Go 1.23.

The next minor version of Mimir (2.14) will likely support Go 1.23.

@pstibrany
Copy link
Member

pstibrany commented Aug 19, 2024

That said, the fix should be as simple as updating github.com/grafana/pyroscope-go/godeltaprof dependency to version v0.1.7.

@narqo
Copy link
Contributor

narqo commented Sep 3, 2024

I believe it's resolved now #9070

@narqo narqo closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants