Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope-rs feedback #127

Open
korniltsev opened this issue Aug 1, 2023 · 1 comment
Open

pyroscope-rs feedback #127

korniltsev opened this issue Aug 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@korniltsev
Copy link
Collaborator

There have been a bunch of feedback on pyroscope-rs. It may worth to investigate. specifically mem leak and signal handlers overhead.

paritytech/polkadot-sdk#804

  • pprof-rs has a high overhead, since it's doing profiling being based on signal handlers (and pyroscope unregisters/registers the signal handlers every 10 seconds).
  • libunwind mechanism is buggy and causes SIGABORTs: SIGABORT when profiling with pyroscope-rs tikv/pprof-rs#219
  • pyroscope-rs repo does not seem under a lot of active maintenance. I also discovered a bug there: fix spurious exit when epoll_wait is interrupted by a signal grafana/pyroscope-rs#125
  • even with frame pointer unwinding and the above fix, after a couple of hours of running the validator with pyroscope enabled, most of the nodes tasks are killed, including the pyroscope agent (I assume there's a memory leak that triggers an OOM somewhere), which leaves the node in an inconsistent but still running state.
@korniltsev korniltsev added the bug Something isn't working label Aug 1, 2023
@ttys3
Copy link

ttys3 commented Apr 18, 2024

high memory usage tikv/pprof-rs#244

before usage of pyroscope-rs: 6M
after usage of pyroscope-rs: 200M+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants