Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TraceQL: Ints can't be compared to floats #4332

Open
joe-elliott opened this issue Nov 15, 2024 · 1 comment · May be fixed by #4391
Open

TraceQL: Ints can't be compared to floats #4332

joe-elliott opened this issue Nov 15, 2024 · 1 comment · May be fixed by #4391
Labels
enhancement New feature or request traceql

Comments

@joe-elliott
Copy link
Member

joe-elliott commented Nov 15, 2024

Currently ints can't be compared to floats. For instance this will never find a matching span:

{ span.floatAttr = 3 }

This may find a matching span:

{ span.floatAttr = 3. }

Tempo will never fully cast/coerce datatypes. This will never work:

{ span.floatAttr = "3" }

But I do think it would be useful for ints and floats to be comparable. Let's add support for searching float columns with int values and vice versa.

Similar to: #4046

@joe-elliott joe-elliott added enhancement New feature or request traceql labels Nov 15, 2024
@ndk ndk linked a pull request Nov 27, 2024 that will close this issue
3 tasks
@ndk
Copy link
Contributor

ndk commented Dec 10, 2024

Here's an idea of how it might be fixed. :)
#4391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request traceql
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants