Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making experimental opentelemetry output #1

Closed
10 tasks done
olegbespalov opened this issue May 15, 2024 · 4 comments · Fixed by grafana/k6#3834
Closed
10 tasks done

Making experimental opentelemetry output #1

olegbespalov opened this issue May 15, 2024 · 4 comments · Fixed by grafana/k6#3834
Assignees

Comments

@olegbespalov
Copy link
Collaborator

olegbespalov commented May 15, 2024

What?

This umbrella task aims to collect all requirements (sub-tasks) needed to make the open telemetry output an experimental output in k6.

Tasks

  1. olegbespalov
  2. olegbespalov
  3. olegbespalov
  4. olegbespalov
  5. 1 of 3
    olegbespalov
  6. olegbespalov

TBD

Why?

OpenTelemetry output is an essential one.

Closes grafana/k6#2557

@cwegener
Copy link

This is really exciting progress.

May I suggest that the extension should follow the following OpenTelemetry standards:

The terminology is important, because as the extension stands right now, it is a bit confusing to read through the structs and functions in the config.go file because the use incorrect terminology.

@olegbespalov
Copy link
Collaborator Author

Hi @cwegener !

Sure, it's a good suggestion, and we'll try to consider it while implementing the Improve output configuration possibility.

Just ensure that I'm getting this statement right:

because as the extension stands right now, it is a bit confusing to read through the structs and functions in the config.go file because the use incorrect terminology.

Do you have concrete renaming examples? I am asking to ensure what the expectations are since some configurations will be coming from K6 (like flushing right now).

@cwegener
Copy link

The main concern is the term receiver, which is wrong. https://opentelemetry.io/docs/concepts/glossary/#receiver

I know that the terminology between k6 and OTEL needs to be reconciled. I.e. k6 has the seemingly informal input and output extension terms. So, this extension whilst being a k6 "output" extension makes use of the OpenTelemetry "exporter" components. https://opentelemetry.io/docs/concepts/glossary/#exporter
So, I think it's fine to use the term OTEL Exporter as part of this k6 output extension. Especially considering that the term "export" / "exporting" is already established in many other k6 output plugins.

@olegbespalov
Copy link
Collaborator Author

@cwegener yeah, totally makes sense 👍 I've opened intermediate (there will be more configuration-related PRs in the future) which removes controversial term #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants