Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Blob #35

Closed
Tracked by #3185
mstoykov opened this issue Mar 20, 2023 · 0 comments · Fixed by #74
Closed
Tracked by #3185

Support Blob #35

mstoykov opened this issue Mar 20, 2023 · 0 comments · Fixed by #74
Assignees
@joanlopez

Comments

@mstoykov
Copy link
Collaborator

I did skip Blob as it seamed to be just bad idea increasing the problems I have tried to explore in this epic issue.

But

  1. it does support streams and hopefully k6 will support streams soon ™️ as well.
  2. It is the default of the API, which means that users will be really confused if we say "we are WebSocket API compatible" and then the default are different :(.

I would want this to be done before we make the extension not experimental.

This does not require that the streams API is even implemented, but it does require that we have a Blob implementation. And that likely will need to be part of k6, somehow.
@olegbespalov olegbespalov mentioned this issue Nov 29, 2023
Open
mstoykov added a commit that referenced this issue Apr 24, 2024
@mstoykov
Warn on not setting binarytype
4548b4c 
This is the first part of #35.

But even if #35 is not finished after this warning is an error we can
safely move this extension in k6.
@mstoykov mstoykov mentioned this issue Apr 24, 2024
Merged
5 tasks
mstoykov added a commit that referenced this issue Apr 24, 2024
@mstoykov
Warn on not setting binarytype
003e6f3 
This is the first part of #35.

But even if #35 is not finished after this warning is an error we can
safely move this extension in k6.
mstoykov added a commit that referenced this issue Apr 24, 2024
@mstoykov
Warn on not setting binarytype
282803b 
This is the first part of #35.

But even if #35 is not finished after this warning is an error we can
safely move this extension in k6.
@mstoykov mstoykov mentioned this issue Apr 24, 2024
Closed
5 tasks
mstoykov added a commit that referenced this issue Apr 25, 2024
@mstoykov
Warn on not setting binarytype
00f76a3 
This is the first part of #35.

But even if #35 is not finished after this warning is an error we can
safely move this extension in k6.
mstoykov added a commit that referenced this issue Apr 25, 2024
@mstoykov
Warn on not setting binarytype (#64)
0c7823e 
* Warn on not setting binarytype

This is the first part of #35.

But even if #35 is not finished after this warning is an error we can
safely move this extension in k6.
@mstoykov mstoykov mentioned this issue Apr 30, 2024
Closed
@joanlopez joanlopez self-assigned this Jun 10, 2024
@joanlopez joanlopez mentioned this issue Jun 18, 2024
Merged
5 tasks
@joanlopez joanlopez mentioned this issue Jul 3, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanlopez joanlopez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Blob grafana/xk6-websockets
2 participants
@mstoykov @joanlopez