Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark GORM-Hibernate created code as @Generated. #274

Open
aulea opened this issue Apr 7, 2021 · 4 comments
Open

Mark GORM-Hibernate created code as @Generated. #274

aulea opened this issue Apr 7, 2021 · 4 comments

Comments

@aulea
Copy link
Contributor

aulea commented Apr 7, 2021

  • Mark all Trait added methods as @Generated
  • Mark all AST transformation added methods/constructions/classes as @Generated

Then example Jacoco could create better code coverage reports.

Origin issue grails/grails-core#11318

aulea added a commit to aulea/gorm-hibernate5 that referenced this issue Apr 7, 2021
aulea added a commit to aulea/gorm-hibernate5 that referenced this issue Apr 7, 2021
…reated with AST transformation, to improve test coverage reports
@boardbloke
Copy link

Hi @aulea - is this change and grails/grails-data-mapping#1445 complete - its something I'd like to see in Grails 4 / 5

@aulea
Copy link
Contributor Author

aulea commented Oct 29, 2021

From my side its complete, waiting Grails team (@puneetbehl) to accept it.
When there will come out some new places, what i may have missed, then those can be solved with new issues/pull-requests.

@boardbloke
Copy link

Hi @puneetbehl - do you have time to accept and merge this and grails/grails-data-mapping#1445? Does anything additional need to be done?

@andersaaberg
Copy link

Please include this in Grails 5, as we cannot use OpenClover in Grails 5 and Jacoco coverage is currently very bad compared to OpenClover in Grails 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants