Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Snapshot Deployment #13571

Open
codeconsole opened this issue Jul 28, 2024 · 10 comments
Open

Document Snapshot Deployment #13571

codeconsole opened this issue Jul 28, 2024 · 10 comments
Assignees

Comments

@codeconsole
Copy link
Contributor

codeconsole commented Jul 28, 2024

Document the Requirements for Deploying to the Snapshot Repository

Discuss

  1. Should SNAPSHOTs continue to go to jfrog starting with 7.x?
  2. Should the SNAPSHOT process require different configuration from the deployment process?

Goals

  1. Configure https://github.com/gpc/export to publish to Snapshot Repository
  2. Configure https://github.com/grails/grails-boot
  3. Fix gradle.plugin is mistakenly publishing a pom under grails-core
    org/grails/grails-core/org.grails.grails-core.gradle.plugin/ Unwanted Artifact?

Working Snapshots
grails-core
grails-gradle-plugin
grails-bom

Not Working
grails-gsp
neo-4j

From @matrei

An example of a simple module, publishing snapshots, is scaffolding.
It uses the org.grails.internal.grails-plugin-publish gradle plugin from grails-gradle-plugin.

build.gradle

plugins {
    id 'java-library'
    id 'eclipse'
    id 'idea'
    id 'org.grails.grails-plugin'
    id 'org.grails.grails-gsp'
    id 'org.grails.internal.grails-plugin-publish'
}
grailsPublish {
    userOrg = "grails"
    githubSlug = 'grails/scaffolding'
    license {
        name = 'Apache-2.0'
    }
    title = "Grails Scaffolding Plugin"
    desc = "Provides scaffolding for Grails applications"
    developers = [puneetbehl: "Puneet Behl"]
}

Then, in the gradle.yml github workflow it publishes on pushevents:

publish:
    if: github.event_name == 'push'
    needs: ['build']
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - name: Set up JDK
        uses: actions/setup-java@v4
        with:
          distribution: 'adopt'
          java-version: '11'
      - name: Publish Artifacts (repo.grails.org)
        id: publish
        uses: gradle/gradle-build-action@v3
        env:
          GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
          GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_USER }}
          GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY: ${{ secrets.GRADLE_ENTERPRISE_BUILD_CACHE_NODE_KEY }}
          ARTIFACTORY_USERNAME: ${{ secrets.ARTIFACTORY_USERNAME }}
          ARTIFACTORY_PASSWORD: ${{ secrets.ARTIFACTORY_PASSWORD }}
        with:
          arguments: -Dorg.gradle.internal.publish.checksums.insecure=true publish

Where is scaffolding publishing to?

@codeconsole codeconsole self-assigned this Jul 29, 2024
@codeconsole
Copy link
Contributor Author

@matrei is scaffolding going to the right place?

@matrei
Copy link
Contributor

matrei commented Jul 29, 2024

@codeconsole
Copy link
Contributor Author

ok, it goes to instead of plugins3-snapshots-locall instead of libs-snapshots-local Thanks

@jeffscottbrown
Copy link
Member

jeffscottbrown commented Jul 31, 2024

Should SNAPSHOTs continue to go to jfrog starting with 7.x?

Are SNAPSHOTs currently being published to jfrog? I believe they may only be published to Artifactory. Is that correct?

@matrei
Copy link
Contributor

matrei commented Jul 31, 2024

Are SNAPSHOTs currently being published to jfrog? I believe they may only be published to Artifactory. Is that correct?

@osscontributor Sorry for me perhaps being ignorant, but isn't JFrog a company, and Artifactory their product for publishing and hosting artifacts? If so, in the context of this discussion, doesn't these two terms mean the same thing?

@codeconsole
Copy link
Contributor Author

@osscontributor Sorry for me perhaps being ignorant, but isn't JFrog a company, and Artifactory their product for publishing and hosting artifacts? If so, in the context of this discussion, doesn't these two terms mean the same thing?

that what I thought, but now I am confused.

@codeconsole
Copy link
Contributor Author

Looks like Neo 4j neglected and not deploying snapshots: grails/gorm-neo4j#603 (comment)

@jeffscottbrown
Copy link
Member

that what I thought, but now I am confused.

I am sorry for the confusion.

@jeffscottbrown
Copy link
Member

@osscontributor Sorry for me perhaps being ignorant, but isn't JFrog a company, and Artifactory their product for publishing and hosting artifacts? If so, in the context of this discussion, doesn't these two terms mean the same thing?

The terms do kind of mean the same thing. The confusion caused was my fault. Yes, JFrog is a company, and Artifactory is a product they produce. Because of the context above I wrongly assumed that JFrog was being used in place of Bintray, where we used to publish releases (I don't think snapshots) but I was mistaken when I assumed that and my response caused more confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants