Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract a Grails Common package that can be shared between GORM & Grails #13850

Open
jdaugherty opened this issue Nov 18, 2024 · 3 comments
Open
Assignees
Labels

Comments

@jdaugherty
Copy link
Contributor

Feature description

There are several utility classes from the Grails 7 migration that have been duplicated between GORM & Grails Core. Since GORM is not meant to depend on Grails Core, we should introduce a common library dependency to avoid code duplication.

Initially, this would include:

  1. A common interface for @Validateable & @GormValidateable
  2. The various org.grails.asm.* classes that were copied from Spring to support annotation reading.
@jeffscottbrown
Copy link
Member

Since GORM is not meant to depend on Grails Core, we should introduce a common library dependency to avoid code duplication.

grails-datastore-gorm-support currently has api dependencies on grails-core and grails-bootstrap (grails-datastore-gorm-support/build.gradle), and compile time dependencies on grails-web-common and grails-web-url-mappings (grails-datastore-gorm-support/build.gradle).

Do you anticipate that all of those dependencies would be removed?

@jdaugherty
Copy link
Contributor Author

Since GORM is not meant to depend on Grails Core, we should introduce a common library dependency to avoid code duplication.

grails-datastore-gorm-support currently has api dependencies on grails-core and grails-bootstrap (grails-datastore-gorm-support/build.gradle), and compile time dependencies on grails-web-common and grails-web-url-mappings (grails-datastore-gorm-support/build.gradle).

Do you anticipate that all of those dependencies would be removed?

It looks like before they were dependencies with explicit exclusions so they could be used in other projects. I assume we should add those exclusions back, but have not dug into it too deeply.

@matrei
Copy link
Contributor

matrei commented Dec 21, 2024

Two classes that have been "temporarily" copied to grails-views-gradle-plugin to decouple grails-views and are candidates for moving to grails-common are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

3 participants