Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated application.yml should not hard code info.app.* values #229

Closed
matrei opened this issue Nov 10, 2023 · 0 comments · Fixed by #232
Closed

Generated application.yml should not hard code info.app.* values #229

matrei opened this issue Nov 10, 2023 · 0 comments · Fixed by #232

Comments

@matrei
Copy link
Contributor

matrei commented Nov 10, 2023

Description

The info.app.name, info.app.version and info.app.grailsVersion configuration values should not be hard coded in the generated grails-app/conf/application.yml file.

In earlier versions of Grails these values where set in application.yml as:

info:
  app:
    name: '@info.app.name@'
    version: '@info.app.version@'
    grailsVersion: '@info.app.grailsVersion@'

In Grails 6 they are set as:

info:
  app:
    name: g610
    version: '0.1'
    grailsVersion: 6.1.0

I believe it's preferable to return these values to placeholders, eliminating the need for updates in multiple locations. It would be even better if we in the future could remove them from the application.yml file, as they contribute unnecessary clutter without providing any value for the developer. But removing them now, for some reason, makes them unavailable in production environment.

@matrei matrei changed the title Generated application.yml should not specify info.app.* values Generated application.yml should not hard code info.app.* values Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant