19. December 2023

[dimakuv]

Agenda

(please write your proposed agenda items in comments under this discussion)

• Dmitrii: moving some "GitHub issues" to "Discussions" under a new category?
  • Sometimes we have "observations about performance and/or validation results", which are currently opened as GitHub issues
  • One example: Performance degradations observed in few workloads when EDMM is enabled #1682
  • GitHub issues are supposed to be actionable, i.e., bugs or feature requests, not general remarks and experimental results
  • GitHub discussions are for this purpose
    • But we don't have a good category to put it in right now: https://github.com/gramineproject/gramine/discussions
    • Maybe "Show and tell"?
    • I propose to create a new category "Validation and evaluation", and we move all such GitHub issues there
• Dmitrii: Open sourcing the new PAL.
  • Final ack to create a separate repo under gramineproject GitHub org
  • Should the repo name contain experimental_ prefix or smth like this?
  • Do I squash the commits? Do I keep them in a separate branch? I don't think I'll have the will power to rebase all my commits to v1.6.

Dmitrii: moving some "GitHub issues" to "Discussions" under a new category?

• Woju: The particular issue 19. December 2023 #1684 does look like an issue -- people expected some results, but actual results are different. So at least originally (before a discussion) it sounds like a legitimate issue, not a "discussion" material.

  • It may be a problem of documentation?

• Kailun: It makes sense to move GitHub issues that can be "closed", but contain valuable info (like perf numbers), to Discussions.

  • But in case of 19. December 2023 #1684, we didn't really analyze these numbers? So it makes sense to have it as an "open issue".
  • What about Scikit-learn benchmark takes very long time to finish (~18 hrs) when EDMM is enabled #1612?
    • Rule of thumb: if maintainers think the behavior is expected (e.g. small perf degradation when EDMM is enabled), then yes, move to Discussions. Otherwise keep as an open issue.

• Dmitrii: as an example, where do we put performance tests on GitHub?

  • Michal: yes, such things should be in Discussions.
  • Woju: yes with caveats, only if such tests are not actionable (don't hint at real bugs).

Created "Performance discussions" category, see https://github.com/gramineproject/gramine/discussions/categories/performance-discussions

Dmitrii: Open sourcing the new PAL

• Acknowledged by maintainers.

• New repo: gramine-tdx, and in description add "Experimental" and also in README with huge letters.

• Reviewing policy can be lax (e.g. only Dmitrii as a reviewer).

• Branching: Woju suggests to frequently rebase to master.