Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-mail address uniqueness check is case sensitive #446

Open
DavidMStraub opened this issue Nov 1, 2023 · 2 comments
Open

E-mail address uniqueness check is case sensitive #446

DavidMStraub opened this issue Nov 1, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@DavidMStraub
Copy link
Member

I just noticed that using different case for the same e-mail address passes the uniqueness check. I think we should convert all e-mail addresses to lower case before storing them.

@DavidMStraub DavidMStraub added the bug Something isn't working label Nov 1, 2023
@Nick-Hall
Copy link
Member

Nick-Hall commented Nov 1, 2023

The local part of an email address is actually case sensitive. Strictly speaking you should keep the original case, but I don't think that this will cause a problem in practice.

@emyoulation
Copy link

Technically, the local part of an eMail address case sensitive according to RFC 5321. However, email service providers have opted to not follow this part of the specification because it created excessive support costs. (Instead they enforce case-sensitivity in Usernames and Passwords.)

It seems like case-sensitivity in the uniqueness check would similarly cause us extra support costs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants