Fixes bug #0013431. Tests for current_date being an empty date #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling routines assume that Today() can be represented either by None or an empty Date instance. This code allows for the latter assumption. Also fixes debug code, which confused %s and str.format style formatting. The style chosen is preferred by pylint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routines that call probably_alive() assume that Today() can be represented either by None or an empty Date instance. This code did not allow for the latter assumption and this PR aims to correct that.
Also fixes debug code, which confused %s and str.format style formatting. The style chosen is preferred by pylint (lazy debug eval)