Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lintly requests changes even if no issues were detected #32

Open
phrdang opened this issue Aug 4, 2020 · 3 comments
Open

Lintly requests changes even if no issues were detected #32

phrdang opened this issue Aug 4, 2020 · 3 comments

Comments

@phrdang
Copy link

phrdang commented Aug 4, 2020

Hello, thank you for making this GitHub action, it's been very useful!

I have the following workflow file:

name: Python (Lintly)

on: pull_request

jobs:
  lint-python:
    name: Lint Python with flake8
    runs-on: ubuntu-latest

    steps:
    - name: Check out Git repository
      uses: actions/checkout@v2

    - name: Set up Python
      uses: actions/setup-python@v1
      with:
        python-version: '3.x'
      
      # Install flake8 and Lintly
    - name: Install Python dependencies
      run: pip install flake8 lintly

      # Run Lintly with flake8
    - name: Lint with flake8
      run: flake8 | lintly --commit-sha=${{ github.event.pull_request.head.sha }}
      env:
        LINTLY_API_KEY: ${{ secrets.GITHUB_TOKEN }}

Oddly, the action requests changes even though there are no linting issues:

Screen Shot 2020-08-04 at 1 32 27 PM

Any help with this issue or a fix of this bug would be appreciated!

@grantmcconnaughey
Copy link
Owner

Hey there! Sorry for the late reply; this somehow fell off my radar. Is this PR in a public repo where I could take a look at the output?

@phrdang
Copy link
Author

phrdang commented Oct 18, 2020

Yep, you can find it here: code4tomorrow/python#39. Brief background on the repository - it's being used as a collection of introductory Python code examples, problems, and solutions. Here's a link to the workflow file as well if you need it; it hasn't changed since I submitted this PR.

@abhishekkundalia
Copy link

I am facing the same issue. Please let me know if we found something.

renefritze pushed a commit to renefritze/Lintly that referenced this issue Feb 21, 2022
…artifactory-check

Sec 1548 adding Artifactory check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants