Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not zoom to route bounding box unconditionally #177

Open
easbar opened this issue Jan 20, 2022 · 0 comments
Open

Do not zoom to route bounding box unconditionally #177

easbar opened this issue Jan 20, 2022 · 0 comments

Comments

@easbar
Copy link
Member

easbar commented Jan 20, 2022

Currently we change the camera position such that a route fits into the window whenever a route request succeeds. However, right now there are two cases coming to my mind where this is not ideal:

  1. We already did an estimation of the bounding box from the given url points and updating the camera position creates a little flickering effect even though the route would be entirely visible anyway

  2. We already updated the map bounds for the first /route request, but when the second /route request (that includes alternative routes) succeeds we update the map bounds again. This is especially annoying when the alternative routes take some time and the user already started zooming/panning the map. E.g. load this URL, pan the map and you will see it jumps back at some point: http://localhost:3000/?point=48.988641%2C7.180233&point=50.856244%2C12.297411&profile=foot&layer=OpenStreetMap

Nothing major, but keeping this as a reminder here.

Related to #306.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant