-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no extra font should be necessary #293
Comments
It fetches this font even if I remove all vector tile layers. And if I remove Noto Sans the network request disappears, but then the font is fetched again from the Google servers again. What is so special about Noto Sans!? (it isn't used elsewhere in our code) But it seems to happen only for Firefox |
Vector layers use client side rendering. Noto Sans covers a wide range of UTF-8 and ensures that the map doesn't display tofu like �. What should be fixed though is the absence of headers like |
If we would not serve the font the browser would just use a different font in this case, so not a big problem, but it cannot hurt to make them work as intended so we included them. The problem here is a different one: firefox fetches the font although the maptiler layer is not used. It is not consistent with the other 2 fonts also required for the Maptiler layer (they are not requested). Chrome handles this properly and requests all 3 fonts only if the maptiler layer is selected. |
I can't see a ttf request when I open https://graphhopper.com/maps/?profile=car&layer=Omniscale in Firefox 107. Only switching layers to a vector based map triggers them. |
I see a request against: https://graphhopper.com/maps/eae34fa8f1e0c4c6d797.ttf (also using Firefox 107). Maybe this depends on the OS? I used Kubuntu. |
Maybe the difference is prefetching: https://github.com/gorhill/uBlock/wiki/Dashboard:-Settings#disable-prefetching |
@karussell for consistency, could you move the fonts to the |
Not sure. Does not seem to be the default https://webpack.js.org/guides/asset-management/#loading-fonts
The content type for the fonts is the problem here, which I fixed in #296 (but needs a server side change on our side too). |
After #288 it seems that we are downloading the Noto Sans font like:
even if we don't use the vector tiles.
The text was updated successfully, but these errors were encountered: