Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 missing support for http batching #2263

Open
3 of 6 tasks
kzlar opened this issue Dec 2, 2024 · 0 comments
Open
3 of 6 tasks

v5 missing support for http batching #2263

kzlar opened this issue Dec 2, 2024 · 0 comments

Comments

@kzlar
Copy link
Contributor

kzlar commented Dec 2, 2024

Feature description

https://github.com/graphile/crystal/blob/main/grafast/grafserv/src/utils.ts#L298C27-L298C56
This check bails when an array of queries is sent to grafserv over http.

Motivating example

HTTP Batching is often used with Apollo client users to reduce the amount of http requests from the clients to the server. See https://www.apollographql.com/docs/react/api/link/apollo-link-batch-http
Postgraphile v4 did support this, so in a way not having this in v5 is a breaking change from v4 that is not documented.

Breaking changes

Shouldn't be any

Supporting development

I [tick all that apply]:

  • am interested in building this feature myself
  • am interested in collaborating on building this feature
  • am willing to help testing this feature before it's released
  • am willing to write a test-driven test suite for this feature (before it exists)
  • am a Graphile sponsor ❤️
  • have an active support or consultancy contract with Graphile
@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Dec 2, 2024
@kzlar kzlar changed the title v5 missing support for batching v5 missing support for http batching Dec 2, 2024
@benjie benjie moved this from 🌳 Triage to 🦥 Sloth in V5.0.0 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🦥 Sloth
Development

No branches or pull requests

1 participant