Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auto-pagination use Relay's Cursor Connection Spec #190

Open
chadoh opened this issue Aug 11, 2022 · 2 comments
Open

Make auto-pagination use Relay's Cursor Connection Spec #190

chadoh opened this issue Aug 11, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@chadoh
Copy link

chadoh commented Aug 11, 2022

The Cursor Connection Spec has become a de-facto standard in the larger GraphQL ecosystem, as far as I can tell. I first learned about it when using Gatsby, which uses the modified version of the Cursor Connection Spec advocated in this blog post: GraphQL Pagination best practices: Using Edges vs Nodes in Connections (this is my favorite post I've seen on the topic, as it is brief and contains links to other resources).

I have found graph-client's auto pagination difficult to work with on the client side, and would enjoy the flexibility and power offered by the Cursor Connection Spec. I also think this could be built in a backwards-compatible way, adding additional ways to access paginated data if people want to, without removing the method of pagination they're already using.

If y'all agree this is worth trying, I'll have time in my schedule in mid-September to try to help add it.

@azf20
Copy link
Contributor

azf20 commented Aug 11, 2022

@dotansimha I think this is a reflection of the implementation in graph-node, I think you were looking into changing that?

@dotansimha
Copy link
Collaborator

@dotansimha I think this is a reflection of the implementation in graph-node, I think you were looking into changing that?

Yeah, we are still working on improving that in graph-node. After improving it on the schema layer, we'll be able to support that out of the box in graph-client.

@dotansimha dotansimha added the enhancement New feature or request label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants