Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use @include or @skip to strip unauthorized fields from a query #29

Open
chris-nissen opened this issue Nov 19, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@chris-nissen
Copy link

Should AuthorizeWith report an error if a field the user isn't authorized for is excluded from the query via the @include or @skip directives? (It currently does.)

@joemcbride joemcbride added the enhancement New feature or request label Nov 19, 2018
@joemcbride
Copy link
Member

joemcbride commented Nov 19, 2018

Indeed it should not report an error. Up for doing a PR for it?

@chris-nissen
Copy link
Author

Bad phrasing on my part. I mean that it should not report an error when the unauthorized field is skipped (or not included), but I think we're on the same page.

I'd like to do a PR, but I haven't done one for a public project before. I'll try to work it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants