Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4D array non optionality error on introspection #4167

Closed
alessdiimperio opened this issue Aug 16, 2024 · 4 comments
Closed

4D array non optionality error on introspection #4167

alessdiimperio opened this issue Aug 16, 2024 · 4 comments

Comments

@alessdiimperio
Copy link

alessdiimperio commented Aug 16, 2024

4D array support has been added in 18.8.
However if you want to make the arrays non optional the introspectionQuery fails and the playhground doesn't work.
The server does run but you can not introspect it.

Using apollo codegen on iOS we cannot build our models seeing as the introspection doesn't work.

example
coordinates: [[[[Float!]!]!]!]! <-- would fail introspection
coordinates: [[[[Float!]]]] <-- does not fail

This seems like a bug 🤔

The best way to get a bug fixed is to provide a pull request with a simplified failing test case (or better yet, include a fix).

@JoviDeCroock
Copy link
Member

We'll need more information than just "it does not work" as this case has explicit tests after https://github.com/graphql/graphql-js/pull/3950/files

@yaacovCR
Copy link
Contributor

yaacovCR commented Oct 1, 2024

Closing for now, we can reopen if more information is provided.

@yaacovCR yaacovCR closed this as completed Oct 1, 2024
@alessdiimperio
Copy link
Author

Sorry i missed this.

basically the server runs and works fine however when trying to introspect it fails the query when we use the following. [[[[Float!]!]!]!]!

however if we remove on level of ! it works

[[[[Float!]!]!]]! <- works

@JoviDeCroock
Copy link
Member

@alessdiimperio again, saying it fails does not help us. We need error messages, a reproduction, a failing test,... anything that can help us see what you see. Have you looked at my comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants