Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github statuses feature doesn't count correctly #41

Open
metajack opened this issue Sep 29, 2014 · 1 comment
Open

github statuses feature doesn't count correctly #41

metajack opened this issue Sep 29, 2014 · 1 comment

Comments

@metajack
Copy link
Collaborator

When using the status API, bors doesn't do any counting of successes. If the number of successes is greater than zero and it sees no failures, it will assume it passed.

For some reason, some status updates aren't going through, so bors will see successes=1 and failures=0 and not wait for the second builder's status to show up. This caused it to land a few PRs that failed tests in Servo.
@metajack
Copy link
Collaborator Author

cc @reiddraper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@metajack