Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify workflows once GitHub releases PR previews #153

Open
vincerubinetti opened this issue Feb 16, 2023 · 1 comment
Open

Simplify workflows once GitHub releases PR previews #153

vincerubinetti opened this issue Feb 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@vincerubinetti
Copy link
Collaborator

vincerubinetti commented Feb 16, 2023

GitHub is working on built-in support for deploy previews on PRs:
community/community#7730

It seems like the feature is in alpha right now, and my guess is it will be ready sometime this year (hopefully very soon!).

Once this becomes available, it will drastically simplify the template template:

  • A gh-pages branch will no longer be needed, and thus we can get rid of that step in the first time setup workflow.
  • rossjrw/pr-preview-action will no longer be needed.
  • The complicated separation and chaining of workflows can go away. Currently needed because a commit from one workflow cannot automatically trigger another workflow, but this will not apply to the built-in triggering of a Pages build. I expect to be able to cut down the number of files and lines of code in .github/workflows by half or more.
@vincerubinetti vincerubinetti added the enhancement New feature or request label Feb 16, 2023
@vincerubinetti vincerubinetti mentioned this issue Apr 6, 2023
@vincerubinetti
Copy link
Collaborator Author

GitHub just added this nice little feature:

Screenshot 2023-04-12 at 11 12 14 AM

So I can get rid of the "update readme" step in the update-url workflow. Currently, it's still needed, because it is a (bad) way to detect if the Pages url has changed and whether to rebuild the site with a new baseurl. But once this issue is implemented, we can add instructions to check this checkbox, and update-url workflow won't be needed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant