v1.3.0 #274
Merged
v1.3.0 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Still want to test this out more, to make extra sure the list filter expressions and workflow changes are working, but reviewers can start taking a look. |
vincerubinetti
commented
Sep 22, 2024
vincerubinetti
commented
Sep 22, 2024
vincerubinetti
commented
Sep 22, 2024
vincerubinetti
commented
Sep 22, 2024
vincerubinetti
commented
Sep 22, 2024
vincerubinetti
commented
Sep 22, 2024
|
@cgreene I think this review is going to fall on you, as it's more of a philosophical design change than a technical change, aside from the one section of code that supports the Ruby expression filtering which is a little weird. I've also "annotated" the diff with comments that hopefully will make it easier to read. |
falquaddoomi
approved these changes
Oct 28, 2024
Co-authored-by: Faisal Alquaddoomi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #272
Closes #269
Closes #191 (hopefully)
New template version checklist:
namefield for all debug/logging steps in workflowsjwalton/gh-find-current-prto get PR number to be more reliable (in rare cases,github.event.numbercan be empty)descriptiongets appended touserdue to missing\nin printf.ymlto.yamlfor consistencyifskipping instead of job-level or workflow-level because of this issue.xml_escapeliquid filter wherever a user/third-party provided field is used in an HTML attribute to prevent special characters breaking HTML rendering. example:aria-label="{{ citation.title }}"andcitation.titleis"Lorem Ipsum" dataset, causing attribute to prematurely close.data_filterto accept Ruby expressions instead of custom syntax. use Rubyevaland define each field in the item as a local variable, e.g.{"animal": "cat"}lets you usefilter="animal == 'cat'".<details>element† due to a github limitation, it wouldn't not run anyway on the auto-created PR. the user must close/reopen the PR, then the regular "on pr" workflow (which includes running "build preview") will run. i've already updated the docs to talk about this. from now on, let's treat auto-opening PR as the only supported way. previously i considered that the user could change
open-prtofalseto have "on schedule" commit updated citations directly tomain, but let's nix that to maintain simplicity. it's probably better that we force the user to review the changes before pushing them to their live site anyway. if we did want to support that in the future, the "build preview" run i removed would have to be changed to a "build site", since we'd want to be re-building themainbranch version of the site, not a preview for a PR.