Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get error with vite+ vue 3 #25

Open
Zony-Zhao opened this issue Oct 12, 2020 · 4 comments
Open

get error with vite+ vue 3 #25

Zony-Zhao opened this issue Oct 12, 2020 · 4 comments

Comments

@Zony-Zhao
Copy link

I just use this lib in a new vite template project.

package.json

image

error

image

@davidmeirlevy
Copy link
Contributor

This package, together with @vue/composition-pi package, are only meant to help you upgrade your project to the new API.
Consider it as a train station.

The API that exists in this package will "natively" exist on the next version of Vuex (4).

So if you're using Vue3 and Vuex4, you can get the same functionality from 'vuex' library directly.

@Valian
Copy link

Valian commented Oct 17, 2020

I'm having the same problem as @Zony-Zhao.

@davidmeirlevy It would be great if we could use it natively, but I think it's not exactly true. According to vuejs/vuex#1725 (comment) that functionality is not in Vuex 4 and probably won't be (at least I don't see any decision in that area).

In addition, in that video https://www.youtube.com/watch?v=ajGglyQQD0k it looks like Vuex 4 will only support Options API. Vuex 5 might be a solution, but who knows how much time is needed? Your helpers really could help people in that weird transition period between Vuex 3 and Vuex 5.

@davidmeirlevy
Copy link
Contributor

Ok so it's probably good idea to create a new version that fits vue@next.

Can you contribute this kind of version?

@Valian
Copy link

Valian commented Oct 18, 2020

@davidmeirlevy I've started working on that, still some tests are failing, mostly ones where we're comparing rendered values. Will dig deeper soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants