Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create git tag/release for 1.1.1, 1.1.2 #74

Open
yshrsmz opened this issue Aug 4, 2022 · 10 comments
Open

create git tag/release for 1.1.1, 1.1.2 #74

yshrsmz opened this issue Aug 4, 2022 · 10 comments

Comments

@yshrsmz
Copy link

yshrsmz commented Aug 4, 2022

so that we can check the diff between releases

@yshrsmz
Copy link
Author

yshrsmz commented Aug 4, 2022

https://www.npmjs.com/package/vuex-composition-helpers

"version": "1.2.0",

also the version in package.json is 1.2.0, but npmjs's latest version is 1.1.2 🤔

@davidmeirlevy
Copy link
Contributor

Hi!

Thanks for the idea.

Regarding NPM, they consider the latest publish as latest, even if it's not the actual latest version.

1.1.x - for Vue 2.0-2.6.x
1.2.x - for Vue ^2.7
2.x.y - for Vue 3+

@yshrsmz
Copy link
Author

yshrsmz commented Aug 5, 2022

really? it seems like 1.1.2 is for Vue 2.7.

@davidmeirlevy
Copy link
Contributor

Nope.
It imports reactivity functions from @vue/composition-api.

@yshrsmz
Copy link
Author

yshrsmz commented Aug 5, 2022

ah true, sorry it was my mistake.
Somehow I messed up my local environment.

@nolde
Copy link
Contributor

nolde commented Aug 8, 2022

What about using vue-demi to avoid the 1.1.x vs 1.2.x version issues?

@davidmeirlevy
Copy link
Contributor

What about using vue-demi to avoid the 1.1.x vs 1.2.x version issues?

It started as a "zero-dependencies" package, and so it should stay.

There are ~25k weekly downloads to this package, so it should avoid affecting users' applications as much as possible, and we should take the dependencies part very seriously.

Also, as a Vue enthusiast myself, I converted all my projects into using Pinia, and I suggest you do it too.
Pinia is a much better state management system, and I prefer to see this package to have less downloads, if that means users have moved on to pinia.

@nolde
Copy link
Contributor

nolde commented Aug 9, 2022

vue-demi also has no dependencies, it just allows your package to be agnostic without implementing it yourself and, theoretically, it would not affect users of your package (it would not be a breaking change). I get your reasoning though.

I want to move to Pinia eventually, but my projects are very large, very complex, and I have a small team. Also, my Vuex setup is working very well, so there is no real reason to justify the change right now. Therefore, this is not something we're ready to do.

This package is not really necessary, but it really helps with code clarity. I can use the store instance directly with Vuex, and was already moving away from it to get ready for Vue 2.7, as I did not realise you had a release for it (there is no proper releases or a changelog to keep track of).

Anyway, it is not my place to tell you what to do with your package. But since you've shared your opinion with me, I just wanted to show you that there are people with different needs and wants, and it might be quite different than yours.

@halnaf
Copy link

halnaf commented Aug 11, 2022

Is it documented somewhere that 1.2.x is for vue 2.7? If so, maybe it could be highlighted a bit more as 2.7 is the lts version for vue 2 going forward..

@davidmeirlevy
Copy link
Contributor

@halnaf no it wasn't.
Would you like to document it and suggest a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants