Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden divider API in support library #111

Open
Mygod opened this issue Nov 18, 2017 · 4 comments
Open

Hidden divider API in support library #111

Mygod opened this issue Nov 18, 2017 · 4 comments

Comments

@Mygod
Copy link
Contributor

Mygod commented Nov 18, 2017

I just discovered that there're app:allowDividerAbove and app:allowDividerBelow APIs. Is it possible to use these?

@gregkorossy
Copy link
Owner

Where do you see these attributes?

@Mygod
Copy link
Contributor Author

Mygod commented Nov 19, 2017

It's in the decompiled Preference class.

@gregkorossy
Copy link
Owner

Technically, I think it would be possible to use these values as these are used in the view holder but it would be difficult to tell when should these override the divider flags.

@Mygod
Copy link
Contributor Author

Mygod commented Jun 11, 2018

In 28.0.0-alpha3, these attributes are being actively used as such:

        <item name="allowDividerAbove">false</item>
        <item name="allowDividerBelow">true</item>
        <item name="iconSpaceReserved">@bool/config_materialPreferenceIconSpaceReserved</item>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants