CompatHelper: bump compat for BlockArrays to 1, (keep existing compat) #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
compathelper/new_version/2024-05-18-00-13-50-581-03011731987
branch
from
93c3cd0
to
0c0ac35
Compare
|
Hi! Is there any chance of testing against BlockArrays v1 and merging? |
…r/new_version/2024-05-18-00-13-50-581-03011731987
…r/new_version/2024-05-18-00-13-50-581-03011731987
|
There were some issues with the change from |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1007 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 195 195
Lines 23567 23567
=======================================
Hits 20914 20914
Misses 2653 2653 ☔ View full report in Codecov by Sentry. |
JordiManyer
deleted the
compathelper/new_version/2024-05-18-00-13-50-581-03011731987
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
BlockArrayspackage from0.12.12, 0.13, 0.14, 0.15, 0.16to0.12.12, 0.13, 0.14, 0.15, 0.16, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.