Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test to RefinementRulesTests.jl that fails and should not #921

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amartinhuertas
Copy link
Member

Solves failing test

@test isconcretetype(eltype(rrules))

09b6e9b for WhiteRefinementRule +
QUADs.

RedRefinementRule still problematic with QUADs
@amartinhuertas
Copy link
Member Author

On a related note, which we do not have to solve in this PR ...

For mixed meshes, I think we are going to have a similar problem, as the polytope is a type parameter of RefinementRule.

@JordiManyer
Copy link
Member

@amartinhuertas Yes, this is something I already encountered in the past. We discussed it, and we ended up agreeing that we will probably have to remove most template parameters from the RefinementRule structure in order to not have problems with mixed meshes... It's a shame, but it should not lead to performance issues since the number of different refinement rules should stay relatively small at all times.

@amartinhuertas
Copy link
Member Author

We discussed it, and we ended up agreeing that we will probably have to remove most template parameters from the RefinementRule structure in order to not have problems with mixed meshes...

Yes, we discussed it, and took some action, as far as I remember (namely, redefinition of type parameters for RefinementRule). These changes solved issues with TRIs but not with QUADs, even with no mixed meshes. In any case, as you say, with mixed meshes is going to be hard to bypass this problem if we stick to type paremeters in RefinementRule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants