Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing behaviour for allocate_vector #963

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Conversation

JordiManyer
Copy link
Member

@JordiManyer JordiManyer commented Dec 6, 2023

Up to now, allocate_vector used the zeros method to create the vector. This not only allocates, but also initializes. Now this is no longer the case.

I have gone through the functions using allocate_vector, allocate_in_domain and allocate_in_range and did the necessary updates.
Notably, the functions zero_free_values and zero_dirichlet_values were not explicitly filling the newly allocated vector with zeros, but were relying on the function to set the values to zero. This is now explicit.

Also, now that the API for allocate_vector is more robust, I've gotten rid of some specializations for zero_free_values that are now redundant.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (68db8cb) 88.08% compared to head (5438ce0) 88.10%.

Files Patch % Lines
src/ODEs/TransientFETools/TransientFESpaces.jl 0.00% 3 Missing ⚠️
src/Algebra/AlgebraInterfaces.jl 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   88.08%   88.10%   +0.02%     
==========================================
  Files         177      177              
  Lines       21077    21075       -2     
==========================================
+ Hits        18566    18569       +3     
+ Misses       2511     2506       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiManyer JordiManyer merged commit 5d369ef into master Dec 7, 2023
7 checks passed
@JordiManyer JordiManyer deleted the allocate-vectors branch December 7, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants