Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: periodic bcs not working #121

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

JordiManyer
Copy link
Member

Closes #119

@JordiManyer JordiManyer self-assigned this Aug 9, 2023
@JordiManyer JordiManyer added the bug Something isn't working label Aug 9, 2023
@JordiManyer JordiManyer changed the base branch from master to partitioned_arrays_v0.3 August 9, 2023 07:06
@JordiManyer JordiManyer marked this pull request as ready for review August 9, 2023 07:21
@JordiManyer
Copy link
Member Author

PeriodicBC tests now run on my local machine. Failed CI is due to not tracking PartitionedArrays#master.

@codecov-commenter
Copy link

Codecov Report

Merging #121 (56561f2) into partitioned_arrays_v0.3 (08b7d8e) will not change coverage.
Report is 1 commits behind head on partitioned_arrays_v0.3.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                   Coverage Diff                   @@
##           partitioned_arrays_v0.3    #121   +/-   ##
=======================================================
  Coverage                     0.00%   0.00%           
=======================================================
  Files                           11      11           
  Lines                         1952    1974   +22     
=======================================================
- Misses                        1952    1974   +22     
Files Changed Coverage Δ
src/Geometry.jl 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amartinhuertas amartinhuertas merged commit b13ec47 into partitioned_arrays_v0.3 Aug 9, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Periodic BCs after porting to PArrays 0.3
3 participants