Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Dirac delta defined by tags #133

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Support for Dirac delta defined by tags #133

merged 2 commits into from
Jul 18, 2024

Conversation

principejavier
Copy link
Member

I implemented support for Dirac deltas, similar to the one in Gridap.jl but restricted to the definition by tags. The definition at arbitrary points will require a parallel search as observed by @JordiManyer in this issue. Although for few points that would not be a problem using tags is enough to have point loads. I also added some tests.

In particular, please, have a look to the definition of this function. Should it be moved to Gridap.jl?

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #133 (fa3584e) into master (50184f2) will not change coverage.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@          Coverage Diff           @@
##           master    #133   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          12      12           
  Lines        2448    2478   +30     
======================================
- Misses       2448    2478   +30     
Files Coverage Δ
src/CellData.jl 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@JordiManyer
Copy link
Member

Hi @principejavier , sorry for the delay... I agree the mentioned code for BoundaryTriangulation is repeated quite a lot. The underlying issue is that although BoundaryTriangulation is defined in general, there are no constructors for arbitrary facet dimension. All constructors end up defaulting to D=Dc-1... I have had to implement this same constructor a couple of times already.
So I do think it would be good to have something like this in Gridap.
@amartinhuertas do you agree?

@principejavier
Copy link
Member Author

@JordiManyer , @amartinhuertas , if you don't mind I will accept this PR to incorporate the development into master and I will open an issue to keep in mind #133 (comment)

@JordiManyer
Copy link
Member

@JordiManyer , @amartinhuertas , if you don't mind I will accept this PR to incorporate the development into master and I will open an issue to keep in mind #133 (comment)

Yeah all good!

@JordiManyer JordiManyer merged commit 333389a into master Jul 18, 2024
6 checks passed
@JordiManyer JordiManyer deleted the dirac_delta branch July 18, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants