-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigMHC and DeepImmuno future support #1151
Comments
Dear @susannasiebert, help us, please. |
My apologies for not replying sooner. Thank you for bringing this to our attention. I plan on updating our forks for both tools to the latest when I have some time for it. I'll let you know when that is completed. |
@susannasiebert Thanks for answer. So we should use your forks, you don't have plans to merge needed files/patches to main repos, correct? |
The difference between our forks and the main repos is only the ability to install the tools via pip, which makes using the algorithms from within pVACtools easier since pVACtools won't have to manage user's installation paths for these tools. As such, we intend to have our fork be functionally up to date with the main repos. If we were to discover any bugs, we'd make PRs for any fixes back to the main repo. As you have discovered, we tried making a PR for our "installation" feature back to BigMHC but they had to revert that PR. It's still in the plans to merge this functionality back into BigMHC at some point but it has been on the lower end of our priority list. |
I have merged the latest, missing BigMHC commits from the main repo to our fork. They were only some text updates to one of the jupyter notebooks so I did not change the version in our setup.py. |
Hello @susannasiebert, thanks for great tool as always.
We recently discovered, that you have support for BigMHC and DeepImmuno, but with your custom installation. Do you plan to upgrade your forks accordingly with original repos?
About BigMHC:
For now, https://github.com/griffithlab/bigmhc is 10 commits ahead of, 4 commits behind https://github.com/KarchinLab/bigmhc.
I've asked about it in KarchinLab/bigmhc#6 (comment), but no answer there, that's why I've created this issue.
Also, I've found merged PR KarchinLab/bigmhc#7, but there are no setup.py in master branch now:
And commit does not belong to any branch:
About DeepImmuno:
Your fork is ahead and don't have any merge problems:
Do you plan to created PR for original repo?
BTW: Last time you said that TF version should be pinned for pVACtools, but I don't see any pin in https://github.com/griffithlab/pVACtools/blob/master/setup.py/ Is in intended?
The text was updated successfully, but these errors were encountered: