Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E tests for OSX #57

Open
luc-tielen opened this issue Dec 12, 2019 · 1 comment
Open

Fix E2E tests for OSX #57

luc-tielen opened this issue Dec 12, 2019 · 1 comment

Comments

@luc-tielen
Copy link
Contributor

When running the e2e tests on OSX, a test failed which checks the generated assembly:

  test/Test/EndToEnd.hs:245:25:
  3) End to end tests, test-data, sum-simple, pipeline-test: sum_simple_exp.grin
       expected: 	.text
                 	.file	"<string>"
                 	.globl	grinMain                # -- Begin function grinMain
                 	.p2align	4, 0x90
                 	.type	grinMain,@function
                 grinMain:                               # @grinMain
                 	.cfi_startproc
                 # %bb.0:                                # %grinMain.entry
                 	movl	$50005000, %edi         # imm = 0x2FB0408
                 	jmp	_prim_int_print         # TAILCALL
                 .Lfunc_end0:
                 	.size	grinMain, .Lfunc_end0-grinMain
                 	.cfi_endproc
                                                         # -- End function
                 	.type	_heap_ptr_,@object      # @_heap_ptr_
                 	.bss
                 	.globl	_heap_ptr_
                 	.p2align	3
                 _heap_ptr_:
                 	.quad	0                       # 0x0
                 	.size	_heap_ptr_, 8


                 	.section	".note.GNU-stack","",@progbits

        but got: 	.section	__TEXT,__text,regular,pure_instructions
                 	.macosx_version_min 10, 13
                 	.globl	_grinMain               ## -- Begin function grinMain
                 	.p2align	4, 0x90
                 _grinMain:                              ## @grinMain
                 	.cfi_startproc
                 ## %bb.0:                               ## %grinMain.entry
                 	movl	$50005000, %edi         ## imm = 0x2FB0408
                 	jmp	__prim_int_print        ## TAILCALL
                 	.cfi_endproc
                                                         ## -- End function
                 	.globl	__heap_ptr_             ## @_heap_ptr_
                 .zerofill __DATA,__common,__heap_ptr_,8,3

                 .subsections_via_symbols

On first look, code seems to be ok (I see the sum constant in the assembly). Should we make it so there are 2 files it can check against depending on current OS?

@andorp
Copy link
Member

andorp commented Dec 29, 2019

Checking against the current OS would be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants