Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force-reload may raise a 429 (TOO_MANY_REQUESTS) error #1107

Closed
fflorent opened this issue Jul 16, 2024 · 3 comments · Fixed by #1197
Closed

Force-reload may raise a 429 (TOO_MANY_REQUESTS) error #1107

fflorent opened this issue Jul 16, 2024 · 3 comments · Fixed by #1197
Assignees
@fflorent
Labels
bug Something isn't working gouv.fr

Comments

@fflorent
Copy link
Collaborator

What happens

When a document has too many requests, one may want to force a document to be reopened. However, the /force-reload endpoint may raise a 429 (TOO_MANY_REQUESTS) error, because it uses the throttled middleware.

Suggestion

Don't use the throttle middleware for this endpoint. What do you think?
@fflorent fflorent added bug Something isn't working gouv.fr labels Jul 16, 2024
@fflorent fflorent moved this to Needs feedback in French administration Board Jul 16, 2024
@fflorent
Copy link
Collaborator Author

fflorent commented Jul 16, 2024 •
edited
Loading

Requesting feedback before starting implementation.

@paulfitz
Copy link
Member

Yes that makes sense!

@fflorent fflorent moved this from Needs feedback to Todo in French administration Board Jul 16, 2024
@fflorent
Copy link
Collaborator Author

@paulfitz Thanks! 🙏

fflorent added a commit to incubateur-territoires/grist-core that referenced this issue Sep 4, 2024
@fflorent
Don't throttle /api/docs/{docId}/force-reload gristlabs#1107
b8fc10d 
When a document has too many requests, one may want to force a document to be reopened. However, the /force-reload endpoint may raise a 429 (TOO_MANY_REQUESTS) error, because it uses the throttled middleware.
@fflorent fflorent mentioned this issue Sep 4, 2024
Merged
4 tasks
@fflorent fflorent self-assigned this Sep 4, 2024
paulfitz pushed a commit that referenced this issue Sep 5, 2024
@fflorent
Don't throttle /api/docs/{docId}/force-reload #1107 (#1197)
2433695 
When a document has too many requests, one may want to force a document to be reopened. However, the /force-reload endpoint may raise a 429 (TOO_MANY_REQUESTS) error, because it uses the throttled middleware.
@github-project-automation github-project-automation bot moved this from Needs feedback to Done in French administration Board Sep 5, 2024
hexaltation pushed a commit to hexaltation/grist-core that referenced this issue Sep 24, 2024
@fflorent @hexaltation
Don't throttle /api/docs/{docId}/force-reload gristlabs#1107 (gristla…
8b76464 
…bs#1197)

When a document has too many requests, one may want to force a document to be reopened. However, the /force-reload endpoint may raise a 429 (TOO_MANY_REQUESTS) error, because it uses the throttled middleware.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fflorent fflorent

Labels
bug Something isn't working gouv.fr
Projects
French administration Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TINY] Don't throttle /api/docs/{docId}/force-reload #1107 incubateur-territoires/grist-core
2 participants
@paulfitz @fflorent