Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set icon for app window #48

Open
mpsijm opened this issue Sep 6, 2024 · 0 comments
Open

Set icon for app window #48

mpsijm opened this issue Sep 6, 2024 · 0 comments

Comments

@mpsijm
Copy link

mpsijm commented Sep 6, 2024

Note that the desktop icon is working fine, but I'm missing the icon in the window button in my XFCE panel:
image

The icon would probably need to be added to the BrowserWindow here: https://github.com/gristlabs/grist-desktop/blob/main/ext/app/electron/GristApp.ts#L185

I just don't know exactly how to import the icon(s) from https://github.com/gristlabs/grist-core/tree/main/static/icons. It's probably as simple as setting a path using setIcon or passing it as option to the constructor, but I don't know what the path should be, as the icons live in a folder outside ext/app.

Note that this change will create a (simple) conflict with #42, which moves the creation of the BrowserWindow to a different function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpsijm