Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial documentation/files need minor update? #1749

Open
ChristopherDrum opened this issue Dec 21, 2023 · 2 comments
Open

Tutorial documentation/files need minor update? #1749

ChristopherDrum opened this issue Dec 21, 2023 · 2 comments
Labels

Comments

@ChristopherDrum
Copy link

Describe the bug

Documentation in basic-tutorial.md references a file at the path
grpc-swift/Sources/Examples/RouteGuide/Client/main.swift
but this file does not exist (see screenshot).

Presumably it is meant to point to RouteGuideClient.swift
The existence of Empty.swift also seems suspicious to me.

image

Expected behaviour

Just expect documentation to keep up to date with the code changes (and vice versa).

@glbrntt
Copy link
Collaborator

glbrntt commented Dec 21, 2023

Thanks @ChristopherDrum, do you want to open a PR to fix this?

@ChristopherDrum
Copy link
Author

@glbrntt Sure, I can do that. I'll see if anything else obvious comes up during my tutorial walkthrough today and make a PR when I finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants