Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileNaming (and other options) are not exposed to the SPM plugin #1818

Open
EraYaN opened this issue Feb 21, 2024 · 2 comments
Open

FileNaming (and other options) are not exposed to the SPM plugin #1818

EraYaN opened this issue Feb 21, 2024 · 2 comments

Comments

@EraYaN
Copy link

EraYaN commented Feb 21, 2024

Is your feature request related to a problem? Please describe it.

When using the SPM Plugin you can not specify FileNaming which will lead often to name collisions which swift really does not like.

Describe the solution you'd like

Some way to either add arbitrary arguments to the protoc call form the json file. Or explicit support for all possible options the generator supports.

Describe alternatives you've considered

I can of course stop using the SPM plugin and generate all the code myself, but I'd much rather keep using the SPM plugin.

Additional context

The pull request this option was added.

@glbrntt
Copy link
Collaborator

glbrntt commented Mar 4, 2024

I don't think there's any reason not to add this; we added it to the SwiftProtobuf plugin (https://github.com/apple/swift-protobuf/blob/main/Plugins/SwiftProtobufPlugin/plugin.swift). Adding it to gRPC Swift should be very similar.

@adam-rocska
Copy link

It would be really lovely to have the "fileNaming": "PathToUnderscores", and its pals introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants