-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for #17 #87
Comments
Comment by googlebot Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Comment by jamdagni86 I signed it! |
Comment by googlebot CLAs look good, thanks! |
Comment by jamdagni86 @trotterdylan - The build is failing in go 1.9 as mentioned in google#378 |
@jamdagni86: I think we fixed the compilation issues. Please let me know if you think this (google#265) is good to merge, in your opinion. |
google#265 opened on Mar 6, 2017 by @jamdagni86
This is something which I could come up with in a couple of hours. The idea is to merge the constituent tuple arguments into a single argument (by joining argument names with τ) and get them unpacked inside the function using array notation.
Let me know your thoughts on the same. Unit tests are still work in progress; will update the PR once they are ready!
The text was updated successfully, but these errors were encountered: