Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-xargs not respecting .gitignore #53

Open
quinnturner opened this issue Oct 1, 2021 · 1 comment
Open

git-xargs not respecting .gitignore #53

quinnturner opened this issue Oct 1, 2021 · 1 comment
Labels
needs design We need to flesh out the design before we can resolve the issue

Comments

@quinnturner
Copy link

quinnturner commented Oct 1, 2021

git-xargs version
What does git-xargs --version show?

git-xargs version v0.0.11

Describe the bug
git-xargs is not respecting .gitignore

To Reproduce
Steps to reproduce the behavior:

#!/usr/bin/env bash

git-xargs \
    --commit-message "Update Yarn Berry to latest canary" \
    --repos ../repos.txt \
    --branch-name chore/update-yarn-berry-canary \
    --loglevel debug \
    "$(pwd)/update-yarn-berry-canary.sh"
#!/usr/bin/env bash

# update-yarn-berry-canary.sh

yarn set version canary
yarn

That results in files being added to node_modules when, in my .gitignore in those projects, I have node_modules/ listed.

Expected behavior

Respect the .gitignore (in this case, node_modules/)

Screenshots
If applicable, add screenshots to help explain your problem.

image

Additional context
Add any other context about the problem here.

@zackproser zackproser added the needs design We need to flesh out the design before we can resolve the issue label Dec 1, 2021
@nwsparks
Copy link

nwsparks commented May 16, 2023

Running into this as well. What's weird is it's partially respecting it. In my case it's only adding one specific package, but the package is definitely covered by the gitignore.

tried on both v0.1.6 and v0.1.7

until this is fixed ending scripts with git clean -fxd or -fXd depending on the situation is probably best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs design We need to flesh out the design before we can resolve the issue
Projects
None yet
Development

No branches or pull requests

3 participants