Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments not working #19

Open
Moulick opened this issue Aug 28, 2023 · 2 comments
Open

Comments not working #19

Moulick opened this issue Aug 28, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Moulick
Copy link

Moulick commented Aug 28, 2023

Describe the bug
The action is not commenting on the pull request

To Reproduce

name: run

on:
  pull_request:
  workflow_dispatch:

permissions:
  id-token: write # This is required for requesting the token from STS
  contents: read # This is required for actions/checkout
  pull-requests: write # This is required for writing comments

env:
  AWS_DEFAULT_REGION: eu-central-1
  REPO_NAME: ${{ github.event.repository.name }}

jobs:
  checks:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v3

      - name: Configure AWS credentials
        uses: aws/configure-aws-credentials@v3
        with: <...>

      - name: Terragrunt plan
        uses: gruntwork-io/terragrunt-action@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          tg_comment: true

          tf_version: "1.5.6"
          tg_version: " 0.50.7"
          tg_dir: "envs/preview"
          tg_command: "plan --terragrunt-log-level trace --terragrunt-debug"
        continue-on-error: true

Expected behavior

The PR should have a comment

Nice to have

These are the last log lines of the action
image

Versions

  • Terragrunt Action version: @v1
  • Environment details (Terragrunt version, Terraform version, etc.):
    • tf_version: "1.5.6"
    • tg_version: " 0.50.7"
@Moulick Moulick added the bug Something isn't working label Aug 28, 2023
@csabaszilveszter
Copy link

csabaszilveszter commented Aug 28, 2023

try tg_comment: 1 instead... reference

@Moulick
Copy link
Author

Moulick commented Aug 29, 2023

ah yes, "1" works.

I can open a PR to support both "true" (as per documentation and more sensible) and "1" (for backwords compatibility)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants