Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official releases of the FASTA database using current time stamp #15

Open
peterjc opened this issue Jul 6, 2022 · 3 comments
Open

Official releases of the FASTA database using current time stamp #15

peterjc opened this issue Jul 6, 2022 · 3 comments

Comments

@peterjc
Copy link

peterjc commented Jul 6, 2022

  1. Goto http://oomycetedb.cgrb.oregonstate.edu/search.html
  2. Click on release 1, dated 2021-03-01, with 885 sequences, comment "First release."
  3. Click on "Download database"
  4. Observe automatically named file name like oomycetedb_whole_2022_07_06_03_05_06.fa

The system appears to us the current timestamp (probably in your time zone not mine?) giving a filename oomycetedb_whole_YYYY_MM_DD_HH_MM_SS.fa which is reasonable for a custom search.

However, for a specific release, it would be far preferable to have the release data and number used, e.g. omycetedb_whole_2021-03-01_release_1.fa in this case. That would be in line with interoperability and reusability aspects of https://en.wikipedia.org/wiki/FAIR_data - reusing the database when the filename is always different is much harder.

@peterjc
Copy link
Author

peterjc commented Jul 6, 2022

I can see that yes, the filename is set to the time stamp in https://github.com/grunwaldlab/OomyceteDB/blob/master/shiny_apps/search/server.r (regardless of what is being downloaded).

You have access to the filename as used on the system, could that not be used on export when a release is selected?

database_path <- file.path(local_release_dir, paste0(selected_database_name(), ".fa"))

@zachary-foster
Copy link
Contributor

I agree this would be a good change and we will likely change to use version numbers and/or release dates in future versions

@peterjc
Copy link
Author

peterjc commented Jul 20, 2022

Perfect - I'll look forward to that. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants