Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix restock area around containers #30

Open
b-mayr-1984 opened this issue Aug 3, 2023 · 3 comments · Fixed by #32
Open

fix restock area around containers #30

b-mayr-1984 opened this issue Aug 3, 2023 · 3 comments · Fixed by #32
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@b-mayr-1984
Copy link
Member

b-mayr-1984 commented Aug 3, 2023

fn_placeRestockArea.sqf is broken since bd99beb.

Same for the menu action to erect a broken camonet (this has been fixed by #32)

Not a show-stopper but until fixed all of this is dead code.

@b-mayr-1984 b-mayr-1984 added bug Something isn't working help wanted Extra attention is needed labels Aug 3, 2023
@senshi-x
Copy link
Contributor

senshi-x commented Aug 4, 2023

Restock area could be fixed and I have started doing so in https://github.com/senshi-x/Shoot_and_Scoot.Tanoa/tree/fix_restock, but I'm questioning if it makes sense to do so at all with the current trigger implementation? Why not use a simple action on the container as well?
Has the added benefit of being easier on performance as well as being easier to implement & maintain.

@b-mayr-1984
Copy link
Member Author

Restock area could be fixed and I have started doing so in https://github.com/senshi-x/Shoot_and_Scoot.Tanoa/tree/fix_restock, but I'm questioning if it makes sense to do so at all with the current trigger implementation? Why not use a simple action on the container as well?

I thought about this simple action. But then it would not be possible to restock the Stomper with it's low amount of supply credits. (Because there is no one there to trigger the action.)

In order to encourage the use of Stompers (currently not in very high demand) I think it is important to not nerf it by lacking the possibility to restock.

Has the added benefit of being easier on performance as well as being easier to implement & maintain.

I am aware of the advantages of the action based approach. I simply don't want to leave the Stomper behind.

@JulesVerner recommended to replace the trigger system with a slowly polling PFH that searches for nearby supply vics.

@b-mayr-1984
Copy link
Member Author

The part with fn_placeRestockArea.sqf is still broken.

#32 never intended to fix this.

Reopened

@b-mayr-1984 b-mayr-1984 reopened this Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants